Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: RIPE expert: handle unknown response for non-ASN types #2461

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

monoidic
Copy link
Contributor

@monoidic monoidic commented Feb 7, 2024

Currently, the RIPE bot successfully handles "No abuse contact found for" messages in response to ASNs, but not for IPs. An example of this would be the address 2001:470:1:c84::12e, which is from a range assigned by ARIN.
This PR removes the filter on only checking for these types of messages on ASNs, allowing for IPs to not cause errors in the bot.

@kamil-certat
Copy link
Contributor

Thanks, it looks good to me!. Do you think it would be possible to easily add a test for that case? And a short changelog entry?

@sebix sebix added this to the 3.3.0 milestone Feb 7, 2024
@monoidic
Copy link
Contributor Author

monoidic commented Feb 8, 2024

Thanks, it looks good to me!. Do you think it would be possible to easily add a test for that case? And a short changelog entry?

Certainly.

@aaronkaplan
Copy link
Member

Thank you, @monoidic

@aaronkaplan aaronkaplan merged commit 618d2ba into certtools:develop Feb 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants